diff --git a/learn_sql_model/models/hero.py b/learn_sql_model/models/hero.py index d4b1991..718fb33 100644 --- a/learn_sql_model/models/hero.py +++ b/learn_sql_model/models/hero.py @@ -65,14 +65,15 @@ class HeroRead(HeroBase): # with config.database.session as session: if session is None: - session = get_config().database.session - statement = select(Hero) - if where != "None" and where is not None: - from sqlmodel import text + engine = get_config().database.engine + with Session(engine) as session: + statement = select(Hero) + if where != "None" and where is not None: + from sqlmodel import text - statement = statement.where(text(where)) - statement = statement.offset(offset).limit(limit) - heroes = session.exec(statement).all() + statement = statement.where(text(where)) + statement = statement.offset(offset).limit(limit) + heroes = session.exec(statement).all() return heroes diff --git a/migrations/versions/e26398d96dd0_add_x_y_size.py b/migrations/versions/e26398d96dd0_add_x_y_size.py new file mode 100644 index 0000000..4219bde --- /dev/null +++ b/migrations/versions/e26398d96dd0_add_x_y_size.py @@ -0,0 +1,33 @@ +"""add x, y, size + +Revision ID: e26398d96dd0 +Revises: a9bb6625c57b +Create Date: 2023-06-10 18:37:04.751553 + +""" +from alembic import op +import sqlalchemy as sa +import sqlmodel + + +# revision identifiers, used by Alembic. +revision = 'e26398d96dd0' +down_revision = 'a9bb6625c57b' +branch_labels = None +depends_on = None + + +def upgrade() -> None: + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('hero', sa.Column('x', sa.Integer(), nullable=False)) + op.add_column('hero', sa.Column('y', sa.Integer(), nullable=False)) + op.add_column('hero', sa.Column('size', sa.Integer(), nullable=False)) + # ### end Alembic commands ### + + +def downgrade() -> None: + # ### commands auto generated by Alembic - please adjust! ### + op.drop_column('hero', 'size') + op.drop_column('hero', 'y') + op.drop_column('hero', 'x') + # ### end Alembic commands ###